Main View keybindings #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrStashley
commented
Mar 15, 2024
| GlobalModel.onMetaArrowDown(); | ||
| return true; | ||
| }); | ||
| keybindManager.registerKeybinding("pane", "session", "app:restartCommand", (waveEvent) => { |
There was a problem hiding this comment.
Does this organization make sense? for what is pane vs what is main view?
…veterm into cole/mainview-keybindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added all of the main view keybindings, including all of the session level ones
I feel like open side bar should automatically add the active line if a line is selected , thoughts?
Also note: Cmd+ArrowDown does not currently work if a tab is selected, because the line terminal keybindings take over
Should I revert that one for now or just keep it the way it is? I feel like it's a small enough thing to keep in and I will work on the term ones next
Those will be the hardest ones I think