Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the auto update checker runs every hour #645

Merged
merged 4 commits into from
May 3, 2024

Conversation

esimkowitz
Copy link
Member

The hour long interval that I set was being subjected to background throttling and wasn't reliably getting invoked. I am shortening the inteval to 10 mins and adding a check within it to see if an hour has passed since the last update check. I am also running the same logic every time the main window is activated. This should ensure that the auto update check happens more reliably and not just on first launch.

Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/645/merge

The test passed.

The validation of the Wave application's ability to execute and display the result of the 'ls' command was successful. The screenshots provided after each step showed the progression from focusing the input field, typing the 'ls' command, executing it by pressing return, and finally displaying the command's output. The output matched the expected directory listing, confirming that the application functions as intended for this test scenario.

Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/645/merge

The test failed.

The task was to validate that Wave shows the result of the 'ls' command. The provided screenshot displayed an error message zsh:1: command not found: ls instead of the expected directory listing, indicating that the 'ls' command was not executed successfully. As a result, since the expected outcome was not achieved, the test did not pass.

Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/645/merge

The test passed.

The goal was to validate that the Wave application shows the result of the 'ls' command, and the provided screenshot confirms that the expected result is displayed in the terminal within the Electron application. The output includes a list of directories and files, which is consistent with the typical output of the 'ls' command. The mouse position and active window state further indicate that no unintended actions occurred, and the focus remained within the Electron application throughout the test.

@esimkowitz esimkowitz merged commit 9b1f5a2 into main May 3, 2024
7 of 8 checks passed
@esimkowitz esimkowitz deleted the evan/fix-auto-update branch May 3, 2024 01:02
Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/645/merge

The test passed.

The tasks were to click Get Started, focus the Wave input with a keyboard shortcut, type 'ls' into the input, press return, and validate that Wave shows the result of 'ls'. Each step was completed successfully as evidenced by the screenshots and desktop state information provided after each action. The final screenshot confirmed that the 'ls' command output matched the expected result, indicating that all objectives were met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant