Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Helper for Yarn Modern #646

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix Build Helper for Yarn Modern #646

merged 3 commits into from
May 3, 2024

Conversation

esimkowitz
Copy link
Member

@esimkowitz esimkowitz commented May 3, 2024

I am removing the Yarn cache from our Build Helper. The actions/node-setup cache option is not compatible with Yarn Modern. With Yarn Modern, the yarn install command that sets up our project-specific yarn config will also install all the module dependencies, meaning we don't need a separate call to resolve these. Altogether, even without the cache, it only takes 21s for Yarn Modern to install and resolve dependencies.

Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/646/merge

The test passed.

The provided screenshots and desktop state notes confirm that all actions were successfully completed. The 'ls' command was typed into the Wave Terminal application, the return key was pressed to execute the command, and the application displayed the expected output of the 'ls' command. There were no errors or issues observed during the execution of these steps, leading to the conclusion that the test passed.

Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/646/merge

The test passed.

The goal was to validate that the Wave application shows the result of the 'ls' command, and the screenshot provided confirms that the output is displayed correctly in the terminal interface. The list of directories and files is consistent with the expected result of the 'ls' command in a Unix-like environment. No overlapping text or other visual issues were observed, indicating that the application rendered the output as intended.

@esimkowitz esimkowitz merged commit 67544c9 into main May 3, 2024
8 of 10 checks passed
@esimkowitz esimkowitz deleted the evan/build-helper-yarn branch May 3, 2024 00:53
Copy link

github-actions bot commented May 3, 2024

TestDriver Summary

wavetermdev/waveterm refs/pull/646/merge

The test passed.

The goal was to validate that the Wave feature in the Electron application shows the result of the 'ls' command, which was successfully achieved. The screenshots provided after each step confirmed that the text Applications, Desktop, and Documents appeared on the screen as part of the 'ls' command output. These directories are typical in a Unix-like system's home directory, indicating that the command executed correctly and the output was displayed as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant