Adding support for different target host than the executing environment #255
Conversation
|
Automatically marking pull request as stale due to lack of activity |
|
@lelia anything I can do to help with this? I can confirm it works as intended on our internal environment 🤗. |
There was a problem hiding this comment.
@rajbos Sorry for the delay here, I haven't worked at Wayfair since the start of the year, so my primary focus has been on other OSS projects at my new company 😔
While I haven't had a chance to explicitly test out the parameter using a GHE instance yet, the overall changes LGTM. My one ask would be that you document the new parameter in the README Inputs section following the same pattern as other params (so, datatype, required/not, description, and example input).
Bonus points if you expand the Usage section to include a code snippet for how one would construct this action to target a dummy GHE instance. Thanks and apologies again for the wait!
|
BTW, feel free to update this PR description to say something like "Fixes #254" so that the related issue will auto-close once this PR merges! |
|
Automatically marking pull request as stale due to lack of activity |
|
Automatically marking pull request as stale due to lack of activity |
|
@lelia : requested changes have been added, please review. |
Description
See the description in #254 as well. We use this on action on our private GitHub Enterprise Server to fork actions on github.com. Since the action runs in the local context by default, we need to make some changes to support this. This PR adds a new optional parameter to support targeting a different environment. If the variable is empty, the current behavior is still the same: it uses the current environment from
actions/core.If the new parameter
targetInstanceUrlis set, it will configure Octokit with that parameter. The rest of the code is the same.Fixes #254
Type of Change
Checklist
Tagging @lelia for visibility 😄.