Custom domain path #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* **src/config.ts** - Add `customImagePath` property to `IS3UserConfig` interface * **src/index.ts** - Add `customImagePath` to defaultConfig in `config` function - Add `customImagePath` configuration option in `handle` function - Update `handle` function to use `customImagePath` for returned URL * **src/uploader.ts** - Add `customImagePath` to `createUploadTaskOpts` interface - Update `createUploadTask` function to use `customImagePath` if provided * **README.md** - Add documentation for `customImagePath` option - Include example usage of `customImagePath` option
* **src/config.ts** - Rename `customImagePath` property to `urlPath` in the `IS3UserConfig` interface * **src/index.ts** - Rename `customImagePath` property to `urlPath` in the default configuration - Rename `customImagePath` property to `urlPath` in the user configuration options * **src/uploader.ts** - Rename `customImagePath` property to `urlPath` in the `createUploadTask` function * **README.md** - Rename `customImagePath` property to `urlPath` in the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:#45
This pull request introduces a new feature for customizing the image URL path in the AWS S3 uploader configuration. The most important changes include updating the
README.mdfile, modifying the configuration interface, and adjusting the implementation to support the newurlPathoption.Documentation updates:
README.md: Added a newurlPathoption to the documentation for customizing the image path. [1] [2]Configuration updates:
src/config.ts: AddedurlPathto theIS3UserConfiginterface.src/index.ts: Updated the default configuration and user configuration to includeurlPath. RenamedcustomImagePathtourlPathin the configuration options. [1] [2]Implementation updates:
src/index.ts: Modified the upload path to useurlPathif provided.src/uploader.ts: Updated the upload task creation to useurlPathfor constructing the final URL. [1] [2] [3]