Add MAIL_SEND_OPTIONS for send_mail
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classes Signed-off-by: jingfelix <jingfelix@outlook.com>
Signed-off-by: jingfelix <jingfelix@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
===========================================
+ Coverage 62.90% 93.93% +31.03%
===========================================
Files 9 9
Lines 585 594 +9
===========================================
+ Hits 368 558 +190
+ Misses 217 36 -181 ☔ View full report in Codecov by Sentry. |
|
It's necessary to update the changelog since this is a new feature and it makes it possible to use non-ascii mail addresses. Please also update the docs and add the unit test for this change. Thanks! |
|
Sorry for the delay, I will finish the improved part today. |
Signed-off-by: jingfelix <jingfelix@outlook.com>
|
Merged, thanks! I made some small improvements to the changelog and code style (1432559). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #38
Flask-Mailman does not set
mail_optionswhen callingsmtplib.SMTP.send_mailinbackends/smtp.py#141. When using a non-ASCII mailbox, the mail might be rejected by server if unsupported.Add a new configuration
MAIL_SEND_OPTIONSforsend_mailto resolve this issue.Note that I leave
CHANGELOG.mdunchanged since I'm not sure whether a new release should be created, as the fix above is quite small.