Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates as many as possible test cases from Django mail module #64

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

tkzt
Copy link
Contributor

@tkzt tkzt commented Nov 28, 2023

Totally, improved the test coverage from 63% to 94%.

fixes #25

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06cd610) 63.07% compared to head (1d7741a) 93.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #64       +/-   ##
===========================================
+ Coverage   63.07%   93.67%   +30.59%     
===========================================
  Files           9        9               
  Lines         585      585               
===========================================
+ Hits          369      548      +179     
+ Misses        216       37      -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/attachments/file.txt Outdated Show resolved Hide resolved
@greyli
Copy link
Collaborator

greyli commented Nov 28, 2023

Could you move this commit to a separate PR? Let's review and merge that first.

@tkzt tkzt force-pushed the feature/add-tests branch 2 times, most recently from 8885b54 to fedf4fc Compare November 29, 2023 01:45
@tkzt
Copy link
Contributor Author

tkzt commented Nov 29, 2023

Could you move this commit to a separate PR? Let's review and merge that first.

Done~

@greyli
Copy link
Collaborator

greyli commented Nov 29, 2023

Please resolve the conflicts and fix the lint issues:

  tests/test_backend.py:10:1: F401 'ssl.SSLError' imported but unused
  tests/test_mail.py:5:1: F401 'unittest.mock' imported but unused
  tests/test_mail.py:7:1: F401 'flask_mailman.utils.DNS_NAME' imported but unused

@tkzt tkzt force-pushed the feature/add-tests branch from fedf4fc to 1d7741a Compare November 30, 2023 01:48
@tkzt
Copy link
Contributor Author

tkzt commented Nov 30, 2023

Please resolve the conflicts and fix the lint issues:

  tests/test_backend.py:10:1: F401 'ssl.SSLError' imported but unused
  tests/test_mail.py:5:1: F401 'unittest.mock' imported but unused
  tests/test_mail.py:7:1: F401 'flask_mailman.utils.DNS_NAME' imported but unused

Finished that 🍻

@greyli greyli merged commit 3624515 into waynerv:master Nov 30, 2023
20 checks passed
@greyli
Copy link
Collaborator

greyli commented Nov 30, 2023

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests from django mail
2 participants