Upgrade to Laravel 10, PHPUnit 10, Button styles, External link indicator #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releasing swiss army knife, profile video, external link icon, and multiple h1 removal 8.3.0
…in most common cases
…oticed a margin issue when adding external to a button so moved the margins around to accomodate
Since PHP 5.4 the short array syntax `[]` may be used instead of `array()`.
Accessing Faker properties was deprecated in Faker 1.14.
In an effort to make upgrading the constantly changing config files easier, Shift defaulted them and merged your true customizations - where ENV variables may not be used.
`<env>` tags have a lower precedence than system environment variables making it easier to overwrite PHPUnit configuration values in additional environments, such a CI. Review this blog post for more details on configuration precedence when testing Laravel: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html
…aken for coverage
Laravel 10.x Shift
PHPUnit 10 Shift
nickdenardis
added
enhancement
dependencies
chrispelzer
reviewed
Aug 18, 2023
|
|
||
| 'default' => [ | ||
| 'database' => 1, |
There was a problem hiding this comment.
Did this get lost or is this part of the .env now to set REDIS_DB to be 1 for the default?
There was a problem hiding this comment.
Need to reconsile the prefix and database envs for database/cache to be database 1 due to database 0 being used by the default PHP redis
$ redis-cli
127.0.0.1:6379> keys *
1) "base_database_base_cache_:981f7afa3e31ed756f98e292d9820a622ad2ae0e"
2) "base_database_base_cache_:981f7afa3e31ed756f98e292d9820a622ad2ae0e:timer"
3) "PHPREDIS_SESSION:dgj68scnj2u75k6drnig19qfa0"
4) "base_database_base_cache_:cms.menuitems.listing80df157015b836bc8c5cc95e915ee4c1"
5) "base_database_base_cache_:cms.promotions.listingd1069900eea792fb7fd81b3ed51dc8a7"
127.0.0.1:6379> select 1
OK
127.0.0.1:6379[1]> keys *
(empty array)
127.0.0.1:6379[1]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four changes in this release:
Bonus: Returns code coverage to 100%