Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Str helper class from database config #648

Closed
wants to merge 1 commit into from

Conversation

nickdenardis
Copy link
Member

Removed Str helper class from database config to satisfy post-site creation Pint validation

Due to the site-setup new... process, the prefix keys are all replaced by the actual site name instead of using the .env variable. This causes the Str import to no longer be needed but the build script doesn't clean up that import and make phplint fails because Str is imported by not used.

This removes the import so Base passes Pint on its own and as a newly generated site.

Demo

Screenshot 2023-08-23 at 6 35 09 AM

@nickdenardis nickdenardis self-assigned this Aug 23, 2023
@nickdenardis nickdenardis requested a review from a team as a code owner August 23, 2023 10:38
@nickdenardis nickdenardis temporarily deployed to build August 23, 2023 10:38 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 7bd87cb on hotfix/8.4.3 into 5246019 on master.

@nickdenardis nickdenardis deleted the hotfix/8.4.3 branch August 23, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants