Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving modular template configuration to childpage and making components consistent #684

Closed
wants to merge 8 commits into from
Closed

Moving modular template configuration to childpage and making components consistent #684

wants to merge 8 commits into from

Conversation

breakdancingcat
Copy link
Member

  • Moved modular template logic to childpage and remove modular template page/controller
  • Updated components to reflect their specific options and have a consistent view across the board
  • Added a new childpage controller test to cover modular template logic

@breakdancingcat breakdancingcat requested a review from a team as a code owner December 19, 2023 19:46
@breakdancingcat breakdancingcat changed the base branch from master to develop December 19, 2023 19:46
@coveralls
Copy link

coveralls commented Dec 19, 2023 •
edited
Loading

Coverage Status

coverage: 100.0% (+0.8%) from 99.218%
when pulling a616071 on feature/new-coverages
into 392fd8d on develop.

nickdenardis
nickdenardis approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breakdancingcat breakdancingcat deleted the feature/new-coverages branch January 10, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdenardis nickdenardis nickdenardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breakdancingcat @coveralls @nickdenardis @chrispelzer