Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accordion upgrade #712

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

breakdancingcat
Copy link
Member

@breakdancingcat breakdancingcat commented May 2, 2024

  • Adding the ability to upload an image with a caption(excerpt) to an accordion item.
  • Options are available to change the orientation from default right, to left, and center(below)
  • Debating adding in italic Lato into Base by default, when it is used it looks much nicer than browser italic, and we use it in the figure component so this wouldn't just be for accordion
  • One downside, these images cannot be lazy loaded because of the accordion js detecting the height
  • Adapted from the Business site
Screenshot 2024-05-01 at 11 36 50 PM Screenshot 2024-05-01 at 11 35 56 PM

@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling ecde667 on feature/accordion-upgrade
into 407fae5 on develop.

Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breakdancingcat breakdancingcat merged commit 31a8b1a into develop May 2, 2024
2 checks passed
@breakdancingcat breakdancingcat deleted the feature/accordion-upgrade branch May 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants