Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flag upgrade #713

Merged
merged 2 commits into from
May 2, 2024
Merged

Feature/flag upgrade #713

merged 2 commits into from
May 2, 2024

Conversation

breakdancingcat
Copy link
Member

@breakdancingcat breakdancingcat commented May 2, 2024

When moving the Flag component back into the component menu, I remembered some improvements that needed to be made

  • The flag can now expand to fit more text within it
  • Used a polygon instead of borders to create the bottom triangle which allows it to expand if needed
  • Included the ability to use em in the title tag instead of having to separate "Make a" and "gift" between title/excerpt. Excerpt is still supported but not necessary. This also allows users to make the entire title em Larger italic if needed
  • (This did not take long and it was a pet peeve)
Screenshot 2024-05-01 at 11 51 53 PM

Obviously we wouldn't approve this, but I wanted to demonstrate it's responsiveness where before it would break to a new line and be all jacked up looking
Screenshot 2024-05-01 at 11 47 00 PM

Screenshot 2024-05-01 at 11 47 22 PM Screenshot 2024-05-01 at 2 11 39 PM

Before
Screenshot 2024-05-01 at 11 50 20 PM

…ext is too long, it can expand, using a polygon instead of borders for the bottom triangle to also enable resizing)
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling c2e2214 on feature/flag-upgrade
into 407fae5 on develop.

Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breakdancingcat breakdancingcat merged commit 2403127 into develop May 2, 2024
2 checks passed
@breakdancingcat breakdancingcat deleted the feature/flag-upgrade branch May 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants