Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/homepage repository - Add catalog component to homepage #715

Closed
wants to merge 7 commits into from

Conversation

AmbyrElan
Copy link
Contributor

@AmbyrElan AmbyrElan commented May 2, 2024

Reason for change

Screenshots / Videos

Before After

@AmbyrElan AmbyrElan requested a review from a team as a code owner May 2, 2024 18:38
@AmbyrElan AmbyrElan changed the base branch from master to develop May 2, 2024 18:38
@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 9a6f5ca on feature/homepage-repository
into 407fae5 on develop.

@AmbyrElan AmbyrElan changed the title Feature/homepage repository - Add catalog component to homepage Feature/homepage repository - WIP - Add catalog component to homepage May 2, 2024
@nickdenardis
Copy link
Member

This says "WIP", is this ready for review? It needs a bit more code coverage.

@AmbyrElan
Copy link
Contributor Author

This says "WIP", is this ready for review? It needs a bit more code coverage.

This is labeled WIP for work in progress since there is more to be done to get back to 100% code coverage.
image

@breakdancingcat
Copy link
Member

@nickdenardis Thanks for looking out.

Ambyr and I used part of our 1:1 to get her started making changes to Base, and I asked her to make a PR in the mean time so we can easily talk about the changes together.

@nickdenardis
Copy link
Member

@breakdancingcat @AmbyrElan
Thanks for the clarification. In GitHub, let's make this a draft PR when it isn't ready for review yet:

Screenshot 2024-05-03 at 9 22 19 AM

@AmbyrElan
Copy link
Contributor Author

image

@AmbyrElan AmbyrElan changed the title Feature/homepage repository - WIP - Add catalog component to homepage Feature/homepage repository - Add catalog component to homepage May 17, 2024
@AmbyrElan AmbyrElan closed this May 17, 2024
@AmbyrElan AmbyrElan deleted the feature/homepage-repository branch May 17, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants