Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide button elements now work when pasted into CMS WYSIWYG #721

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

nickdenardis
Copy link
Member

Reason for change

This resolves the issue with <div> elements inside <a> elements being stripped when copy/pasted into the CMS.

This change only affects the visible code in the styleguide. The typical <div> child elements will still be used for the template component output as they don't need to change.

Reminders

  • Update package version number
  • Frontend accessibility check
  • Styleguide example in place
  • New functionality covered by tests
  • Screenshots of multiple screen sizes

Demo

Before After
Screenshot 2024-06-28 at 2 07 33 PM Screenshot 2024-06-28 at 2 12 02 PM

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling a00570e on feature/button-fixes
into 4d4d6d3 on develop.

@nickdenardis nickdenardis merged commit a00570e into develop Jul 8, 2024
2 checks passed
@breakdancingcat breakdancingcat self-requested a review July 10, 2024 17:27
@nickdenardis nickdenardis deleted the feature/button-fixes branch August 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants