Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/policy numbering #728

Merged
merged 26 commits into from
Sep 5, 2024
Merged

Feature/policy numbering #728

merged 26 commits into from
Sep 5, 2024

Conversation

AmbyrElan
Copy link
Contributor

@AmbyrElan AmbyrElan commented Sep 3, 2024

Policy numbering was throwing a stylelint error.
After pulling in develop/master branches, the policy-numbering class was in its own scss file as well as the content scss file.

  • Removed policy-numbering class from content scss class
  • Ran the linter again and the tests passed.
  • Tested the code on the front end and it is working when adding the policy-numbering class to the <ol> attr.
image
<ol class="policy-numbering">
	<li>This will begin the section heading 1.0</li>
	<li>This will begin the section heading 2.0</li>
	<li>This will begin the section heading 3.0
	<ol>
		<li>Sub section 3.1 begins</li>
		<li>Sub section 3.2 begins</li>
		<li>Sub section 3.3 begins
		<ul>
			<li>Sub section a. begins</li>
			<li>Sub section b. begins
			<ul>
				<li>Sub section i. begins</li>
				<li>Sub section ii. begins</li>
			</ul>
			</li>
		</ul>
		</li>
	</ol>
	</li>
</ol>
Mobile Desktop
image image

breakdancingcat and others added 25 commits May 1, 2024 23:09
…ext is too long, it can expand, using a polygon instead of borders for the bottom triangle to also enable resizing)
@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 20d6719 on feature/policy-numbering
into 90f115c on develop.

@nickdenardis
Copy link
Member

@AmbyrElan
Perhaps your report may have been out of date, the policy numbering was removed from the main content file in this PR:
https://github.com/waynestate/base-site/pull/725/files

This needs some visual work before it can be put into a release. Let's work that out in Basecamp and then put in another PR once it is complete.

@AmbyrElan
Copy link
Contributor Author

@AmbyrElan Perhaps your report may have been out of date, the policy numbering was removed from the main content file in this PR: https://github.com/waynestate/base-site/pull/725/files

This needs some visual work before it can be put into a release. Let's work that out in Basecamp and then put in another PR once it is complete.

@nickdenardis , after fetching and pulling develop, the policy numbering class was still in the content scss file and threw the same errors for me that you showed for why you pushed the update to deactivate the feature but it seems to be fixed on my end now.

I updated the example with more text and re-ran the linter. Everything is checking out on my end. I'm putting updated screenshots in the PR description.

Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@AmbyrElan AmbyrElan merged commit dabe456 into develop Sep 5, 2024
2 checks passed
@AmbyrElan AmbyrElan deleted the feature/policy-numbering branch September 5, 2024 15:02
@breakdancingcat
Copy link
Member

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants