Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Setting the base page controller data to array. #740

Closed
wants to merge 1 commit into from
Closed

fix: Setting the base page controller data to array. #740

wants to merge 1 commit into from

Conversation

Fw7424
Copy link
Contributor

@Fw7424 Fw7424 commented Oct 8, 2024

issue with hero page info coming in as string when array is expected

This issue shows up when trying to contained hero pages to full-width via modular component.

@Fw7424 Fw7424 requested a review from a team as a code owner October 8, 2024 13:29
breakdancingcat
breakdancingcat approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@breakdancingcat breakdancingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 89b7cec on hotfix/8.11.2
into fb428a2 on master.

@Fw7424 Fw7424 closed this Oct 8, 2024
@Fw7424 Fw7424 deleted the hotfix/8.11.2 branch October 8, 2024 13:32
nickdenardis
nickdenardis reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Not dealbreakers at this point, but ideally:

  1. Possible to add the before and after screenshots?
  2. Is there a test we can add to prevent regressions in the future?

@nickdenardis nickdenardis mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdenardis nickdenardis nickdenardis left review comments

@breakdancingcat breakdancingcat breakdancingcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fw7424 @coveralls @nickdenardis @breakdancingcat