News data array adjusted for component loop #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a new PR for additional changes to how the styleguide data is fed in. |
nickdenardis
requested changes
Jan 7, 2025
There was a problem hiding this comment.
If we are going to introduce two new factories, can we update the original Article factory to use the two new ones instead of having duplicate code?
https://github.com/waynestate/base-site/blob/master/factories/Article.php
This would remove some duplication.
…is could be refined but would require some changes that could be conflicting.
|
@nickdenardis I made the change to the Article factory. https://github.com/waynestate/base-site/blob/d8cfd9c913fc051c7f876ffe3e748fcf829ac9de/factories/Article.php |
Fw7424
requested review from
nickdenardis,
chrispelzer,
breakdancingcat,
tomkrupka,
anthonywayne and
AmbyrElan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/43dbbd5850c14a7f954d7bfb2a126d9e?sid=199fbdae-0f53-4e8d-8325-6aec184f9efd
This is a new pull request due to alot of changes on the previous one. This includes changing how the styleguide is fed data.