Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Accordion cutting off content #775

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

breakdancingcat
Copy link
Member

Because of how browsers handle margins (margins of adjacent elements overlap) when the accordion.js is calcuating the inner height, it is not accounting for the top margin of the first heading/element.

This change removes the top margin of any first element within the "fold".

Before After
image image

@breakdancingcat breakdancingcat requested a review from a team as a code owner January 29, 2025 22:03
@breakdancingcat breakdancingcat merged commit 88d1733 into develop Jan 29, 2025
1 check passed
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 88d1733 on feature/accordion-fold-margin
into f2e3791 on develop.

Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants