Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX | Menu Top - Header Title Double | Padding For Accesibility #777

Closed
wants to merge 1 commit into from
Closed

FIX | Menu Top - Header Title Double | Padding For Accesibility #777

wants to merge 1 commit into from

Conversation

KyleApsey
Copy link

@KyleApsey KyleApsey commented Feb 4, 2025 •
edited
Loading

Reason for change

Why this change is taking place?
Update the header title double to be 24 px high to meet accessibility requirement

  • Added padding to the sur-title to ensure that appropriate interactive element size is applied

Relevant links

Reminders

  • Update package version number
  • Frontend accessibility check
  • Styleguide example in place
  • New functionality covered by tests
  • Screenshots of multiple screen sizes

Demo

Before After
before after

@KyleApsey KyleApsey added this to the 8.14.0 Release milestone Feb 4, 2025
@KyleApsey KyleApsey requested a review from a team as a code owner February 4, 2025 19:31
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling f027ad4 on feature/menu-top-surtitle-padding
into b1b9652 on develop.

@KyleApsey KyleApsey closed this Feb 4, 2025
@KyleApsey KyleApsey deleted the feature/menu-top-surtitle-padding branch February 4, 2025 19:36
@chrispelzer
Copy link
Member

👍🏼

@KyleApsey KyleApsey mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breakdancingcat breakdancingcat breakdancingcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.14.0 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleApsey @coveralls @chrispelzer @breakdancingcat