Skip to content

Commit

Permalink
feat: support for 8.3 php images (#37)
Browse files Browse the repository at this point in the history
  • Loading branch information
lotyp authored Apr 3, 2024
1 parent 4d096fb commit 4a690fb
Show file tree
Hide file tree
Showing 14 changed files with 530 additions and 57 deletions.
13 changes: 13 additions & 0 deletions .dive-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
rules:
# If the efficiency is measured below X%, mark as failed.
# Expressed as a ratio between 0-1.
lowestEfficiency: 0.95

# If the amount of wasted space is at least X or larger than X, mark as failed.
# Expressed in B, KB, MB, and GB.
highestWastedBytes: 20MB

# If the amount of wasted space makes up for X% or more of the image, mark as failed.
# Note: the base image layer is NOT included in the total image size.
# Expressed as a ratio between 0-1; fails if the threshold is met or crossed.
highestUserWastedPercent: 0.20
224 changes: 197 additions & 27 deletions .github/workflows/build-latest.yml
Original file line number Diff line number Diff line change
@@ -1,43 +1,213 @@
---

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

on: # yamllint disable-line rule:truthy
workflow_dispatch:
pull_request:
branches:
- master

env:
DOCKER_NAMESPACE: wayofdev/php-base
GHCR_NAMESPACE: ghcr.io/wayofdev/docker-php-base

name: 🚀 Build docker images with latest tag

jobs:
# https://docs.github.com/en/enterprise-cloud@latest/actions/learn-github-actions/expressions#example-returning-a-json-object
prepare:
runs-on: "ubuntu-latest"
outputs:
matrix: ${{ steps.matrix.outputs.matrix }}
build:
strategy:
fail-fast: false
matrix:
os_name: ["alpine"]
php_version: ["8.1", "8.2"]
php_type: ["fpm", "cli", "supervisord"]
builder: [{arch: "amd64", os: "ubuntu-latest"}, {arch: "arm64", os: "ubuntu-latest"}]
runs-on: ${{ matrix.builder.os }}
steps:
- name: ⚙️ Generate matrix
id: matrix

- name: 🌎 Set environment variables
run: |
echo 'matrix={
"os_name": ["alpine"],
"php_version": ["8.1", "8.2"],
"php_type": ["fpm", "cli", "supervisord"]
}' | tr -d '\n' >> $GITHUB_OUTPUT
php_version="${{ matrix.php_version }}"
tag="${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}-${{ matrix.builder.arch }}"
php_version_slug="${php_version//./}"
target="php-${php_version_slug}-${{ matrix.php_type }}-${{ matrix.os_name }}"
echo "TARGET=${target}" >> $GITHUB_ENV
echo "PLATFORM_CACHE_TAG=${tag}" >> $GITHUB_ENV
build:
needs: prepare
strategy:
matrix: ${{ fromJson(needs.prepare.outputs.matrix )}}
uses: wayofdev/gh-actions/.github/workflows/build-image.yml@master
with:
os: "ubuntu-latest"
push-to-hub: true
image-namespace: "wayofdev/php-base"
image-template-path: "./dist/base"
image-template: ${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}
image-version: latest
secrets:
docker-username: ${{ secrets.DOCKER_USERNAME }}
docker-password: ${{ secrets.DOCKER_TOKEN }}
- name: 📦 Check out the codebase
uses: actions/checkout@v4

- name: 🤖 Generate dist files
run: ansible-playbook src/playbook.yml -l ${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}

- name: 💻 Set up Docker for MacOS
if: ${{ matrix.builder.os == 'macos-latest' }}
uses: docker-practice/actions-setup-docker@master

- name: 🖥️ Setup docker QEMU
uses: docker/setup-qemu-action@v3

- name: 🛠️ Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
buildkitd-flags: "--debug"

- name: 🐳 Extract docker meta data
id: meta
uses: docker/metadata-action@v5
with:
images: |
${{ env.DOCKER_NAMESPACE }}
${{ env.GHCR_NAMESPACE }}
tags: |
type=raw,event=branch,value=latest
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
flavor: |
latest=false
prefix=${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}-
- name: ⚙️ Rename meta bake definition file
run: |
mv "${{ steps.meta.outputs.bake-file }}" "/tmp/bake-meta-${{ env.PLATFORM_CACHE_TAG }}.json"
cat "/tmp/bake-meta-${{ env.PLATFORM_CACHE_TAG }}.json"
- name: 📤 Upload meta bake definition
uses: actions/upload-artifact@v4
with:
name: bake-meta-${{ env.PLATFORM_CACHE_TAG }}
path: /tmp/bake-meta-*.json
if-no-files-found: error
retention-days: 1

- name: 🔑 Login to docker-hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_TOKEN }}

- name: 🔑 Login to GHCR
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: 🚀 Bake image and push to docker-hub and GHCR
id: bake
uses: docker/bake-action@v4
with:
targets: ${{ env.TARGET }}
files: |
./docker-bake.hcl
/tmp/bake-meta-${{ env.PLATFORM_CACHE_TAG }}.json
set: |
*.tags=
*.platform=linux/${{ matrix.builder.arch }}
*.cache-from=type=gha,scope=build-${{ env.PLATFORM_CACHE_TAG }}
*.cache-to=type=gha,scope=build-${{ env.PLATFORM_CACHE_TAG }}
*.output=type=image,"name=${{ env.DOCKER_NAMESPACE }},${{ env.GHCR_NAMESPACE }}",push-by-digest=true,name-canonical=true,push=${{ github.event_name != 'pull_request' }}
- name: 🔍 Debug Bake Metadata Output
run: |
echo "${{ steps.bake.outputs.metadata }}"
- name: 🔍 Debug baked image
run: |
tag=$(jq -r '.target."docker-metadata-action".args.DOCKER_META_VERSION' /tmp/bake-meta-${{ env.PLATFORM_CACHE_TAG }}.json)
if [ -z "$tag" ]; then
echo "Tag is empty, skipping inspect."
else
echo "Tag extracted: $tag"
docker buildx imagetools inspect ${{ env.DOCKER_NAMESPACE }}:${tag}
fi
- name: 📥 Export digest
run: |
mkdir -p /tmp/digests
echo "Bake Metadata: ${{ steps.bake.outputs.metadata }}"
digest=$(echo '${{ steps.bake.outputs.metadata }}' | jq -r '.["${{ env.TARGET }}"]["containerimage.digest"]')
if [[ -z "$digest" || "$digest" == "null" ]]; then
echo "Digest not found."
exit 1
fi
echo "Digest: $digest"
touch "/tmp/digests/${digest#sha256:}"
- name: 📤 Upload digest
uses: actions/upload-artifact@v4
with:
name: digests-${{ env.PLATFORM_CACHE_TAG }}
path: /tmp/digests/*
if-no-files-found: error
retention-days: 1

merge:
needs: build
runs-on: ubuntu-latest
steps:

- name: 📥 Download meta bake definitions
uses: actions/download-artifact@v4
with:
pattern: bake-meta-*
path: /tmp

- name: 📥 Download meta bake definitions
uses: actions/download-artifact@v4
with:
pattern: digests-*
path: /tmp/digests/*

- name: Print all download artifact files
run: |
ls -la /tmp
ls -la /tmp/digests
- name: 🔑 Login to docker-hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_TOKEN }}

- name: 🔑 Login to GHCR
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: 🖥️ Setup docker QEMU
uses: docker/setup-qemu-action@v3

- name: 🛠️ Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
buildkitd-flags: "--debug"

- name: Create manifest list and push
run: |
# Aggregate all tags from the meta files
TAGS=$(jq -r '.target."docker-metadata-action".tags[]' /tmp/meta/bake-meta-*.json | sort -u)
# Loop through each tag and create a manifest list
for TAG in $TAGS; do
FULL_TAGS=()
for FILE in /tmp/meta/bake-meta-*.json; do
if jq -e --arg TAG "$TAG" '.target."docker-metadata-action".tags[] | select(. == $TAG)' $FILE > /dev/null; then
# Extract the repository and digest for the current platform
REPO=$(jq -r --arg TAG "$TAG" '.target."docker-metadata-action".tags[] | select(. == $TAG)' $FILE | cut -d':' -f1)
DIGEST=$(jq -r '.["'$REPO'"]["containerimage.digest"]' $FILE)
FULL_TAGS+=("$REPO@$DIGEST")
fi
done
# Create and push the manifest list for the current tag
docker buildx imagetools create "${FULL_TAGS[@]}" -t "$TAG"
done
...
2 changes: 1 addition & 1 deletion .github/workflows/build-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: |
echo 'matrix={
"os_name": ["alpine"],
"php_version": ["8.1", "8.2"],
"php_version": ["8.1", "8.2", "8.3"],
"php_type": ["fpm", "cli", "supervisord"]
}' | tr -d '\n' >> $GITHUB_OUTPUT
Expand Down
111 changes: 111 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
---

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

on:
push:
branches:
- master
paths-ignore:
- '**.md'
pull_request:
paths-ignore:
- '**.md'

env:
DOCKER_NAMESPACE: wayofdev/php-base
GHCR_NAMESPACE: ghcr.io/wayofdev/docker-php-base

name: 🧪 Test Docker images

jobs:
test:
strategy:
fail-fast: false
matrix:
os_name: ["alpine"]
php_version: ["8.1", "8.2", "8.3"]
php_type: ["fpm", "cli", "supervisord"]
builder: [{arch: "amd64", os: "ubuntu-latest"}]
runs-on: ${{ matrix.builder.os }}
steps:

- name: 🌎 Set environment variables
run: |
php_version="${{ matrix.php_version }}"
tag="${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}-${{ matrix.builder.arch }}"
php_version_slug="${php_version//./}"
target="php-${php_version_slug}-${{ matrix.php_type }}-${{ matrix.os_name }}"
echo "TARGET=${target}" >> $GITHUB_ENV
echo "PLATFORM_CACHE_TAG=${tag}" >> $GITHUB_ENV
- name: 📦 Check out the codebase
uses: actions/checkout@v4

- name: 🛠️ Install goss and dgoss
uses: e1himself/goss-installation-action@v1.2.1
with:
version: v0.4.6

- name: 🤖 Generate dist files
run: ansible-playbook src/playbook.yml -l ${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}

- name: 🖥️ Setup docker QEMU
uses: docker/setup-qemu-action@v3

- name: 🛠️ Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
buildkitd-flags: "--debug"

- name: 🔑 Login to docker-hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_TOKEN }}

- name: 🔑 Login to GHCR
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: 🐳 Extract docker meta data
id: meta
uses: docker/metadata-action@v5
with:
images: |
${{ env.DOCKER_NAMESPACE }}
${{ env.GHCR_NAMESPACE }}
tags: |
type=raw,event=branch,value=latest
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
flavor: |
latest=false
prefix=${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}-
- name: 🧪 Bake image for testing
id: bake
uses: docker/bake-action@v4
with:
targets: ${{ env.TARGET }}
files: |
./docker-bake.hcl
${{ steps.meta.outputs.bake-file }}
set: |
*.tags=
*.platform=linux/${{ matrix.builder.arch }}
*.cache-from=type=gha,scope=build-${{ env.PLATFORM_CACHE_TAG }}
*.cache-to=type=gha,scope=build-${{ env.PLATFORM_CACHE_TAG }}
*.output=type=docker,"name=${{ env.DOCKER_NAMESPACE }},${{ env.GHCR_NAMESPACE }}",name-canonical=true,push=false
- name: 🧪 Test Docker image
run: |
export IMAGE_TEMPLATE=${{ matrix.php_version }}-${{ matrix.php_type }}-${{ matrix.os_name }}
export IMAGE_TAG=${{ env.DOCKER_NAMESPACE }}:latest
make test
Loading

0 comments on commit 4a690fb

Please sign in to comment.