Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #410

Merged
merged 156 commits into from
Oct 28, 2023
Merged

Dev #410

merged 156 commits into from
Oct 28, 2023

Conversation

KG6KZZ
Copy link

@KG6KZZ KG6KZZ commented Jul 9, 2022

Hello John,

My name is Jason Kim (KG6KZZ). I would like to thank you for your work on Direwolf TNC development. This had been a great learning experience using it and trying on tweaking the software on my Windows 10 system.

I was able to make few improvements on the software downloaded from your GitHub v1.7 Dev branch, but, unable to push my changes for your review.

Since I am still learning to use GitHub, I am having bit of difficulty getting over the GitHub push authentication errors.

Anyhow, what I wanted to propose is to add support for using CM108 GPIO in Opendrain mode for PTT activation. This eliminates the need for adding external Open Collector Transistor for pulling down on PTT pin, which simplifies the HW modification needed for CM108 USB audio cards.

In so doing, I had to correct few issues relating to Windows 10 operations as listed below. Attached is my edited source files with my change notes with "KG6KZZ" comments on the files for your reference.

Please let me know if these could be accommodated.
Thank you.

Jason Kim
(KG6KZZ)

==========================================================================
KG6KZZ updated latest dev branch files: (direwolf_1.7x)

  1. Updated to add PTT option for Opendrain mode on CM108 GPIO pins
    (ptt.c, cm108.c, audio.h, config.c, generic.conf)
  2. Increased MAX_FILTER_SIZE to 512 to support 9600 baud using 48000 sample rate (I have verified it working fine with my local BBS server)
  3. Corrected erroneous flagging of command error when cmd.hdr length is 0
  4. Adjusted to lower flagging of inverted header for exact match only.
  5. Increased Device Name Path length to 256 to avoid Windows 10 errors.

Changes staged for commit:
modified: CMakeLists.txt
modified: conf/generic.conf
new file: doc/Direwolf_1.7x_TNC_User-Guide.pdf
modified: src/audio.h
modified: src/cm108.c
modified: src/cm108.h
modified: src/config.c
modified: src/dwsock.c
modified: src/fsk_demod_state.h
modified: src/il2p_rec.c
modified: src/ptt.c
modified: src/server.c
KG6KZZ_1.7x_changes.zip

ew1abz and others added 30 commits March 29, 2020 19:12
cmake: Avoid try_run when cross-compiling
'A' uses mark and space filters but simpler and cleaner
than earlier attempts.
New 'B' uses a different technique where the demodulated
signal is proportional to the frequency.
(including 1200/2200Hz) to -x command line argument in Direwolf.
This is useful for calibrating FM deviation using a meter,
devcal, or manually. See:

https://groups.io/g/direwolf/topic/setting_deviation/78633292

Options are:

-x a: alternating mark/space tones (original functionality)
-x m or -x 1: steady mark tone (e.g. 1200Hz)
-x s or -x 2: steady space tone (e.g. 2200Hz)
-x p: set PTT only - for RTL-SDR adjustments

Scope tested with mark_freq>=300Hz and space_freq<=5000Hz.
Returns an error message if mark/space frequencies are set
to 0.
This allows client applications to locate the IP addresses and the port of
the KISS TCP service, allowing the end user to just select a Dire Wolf from
a list instead of trying to guess its dynamic IP address and typing it in
manually.  This is especially convenient on mobile devices.

On Linux, the standard Avahi daemon is used via dbus and the avahi-client
library.  Building with it requires installing the development header
package; README.md is updated accordingly.

On Mac, the MacOS dnssd API is used:
https://developer.apple.com/documentation/dnssd?language=objc

I don't have Windows, but more recent Windows 10 builds apparently have
a working DNS-SD mDNS implementation that can be used on 64-bit builds.
Steady FM deviation calibration tones for -x
wb2osz and others added 29 commits May 21, 2023 21:32
We were checking `*t` for end of string instead of `*c`, but `t` never changes, so we would run off of the end of the buffer and output a very large number of config errors before eventually crashing.
rig_open call. If the rig_open continues to fail after 5 tries,
exit.
@wb2osz wb2osz merged commit de293a1 into master Oct 28, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.