Skip to content

Refactor Ornamentation #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Refactor Ornamentation #212

merged 2 commits into from
Dec 14, 2024

Conversation

wbaldoumas
Copy link
Owner

Description

Refactor how ornamentation is applied - cleaning after each processor pass to increase the likelihood of non-conflicting ornamentations being applied. Shuffle ornamentation processors after each pass to increase variety.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (3d52763) to head (6e51af6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   97.33%   97.21%   -0.13%     
==========================================
  Files         153      153              
  Lines        3868     3874       +6     
  Branches      415      418       +3     
==========================================
+ Hits         3765     3766       +1     
- Misses         79       83       +4     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbaldoumas wbaldoumas merged commit 8ecfa2a into main Dec 14, 2024
6 of 7 checks passed
@wbaldoumas wbaldoumas deleted the refactor-ornamentation branch December 14, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant