Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter composition strategy #33

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Conversation

wbaldoumas
Copy link
Owner

Description

Update the composition strategy to automatically invalidate choices which would result in voices extending beyond their configured range.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (650bcd1) 99.56% compared to head (50d9335) 99.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   99.56%   99.58%   +0.01%     
==========================================
  Files          26       26              
  Lines         462      479      +17     
  Branches       29       31       +2     
==========================================
+ Hits          460      477      +17     
  Misses          1        1              
  Partials        1        1              
Files Coverage Δ
...osition/Configurations/CompositionConfiguration.cs 100.00% <100.00%> (ø)
src/BaroquenMelody.Library/Composition/Note.cs 100.00% <100.00%> (ø)
...rary/Composition/Strategies/CompositionStrategy.cs 100.00% <100.00%> (ø)
...Melody.Library/Extensions/NoteContextExtensions.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbaldoumas wbaldoumas marked this pull request as ready for review November 5, 2023 01:14
@wbaldoumas wbaldoumas merged commit 1f973f7 into main Nov 5, 2023
9 checks passed
@wbaldoumas wbaldoumas deleted the smarter-composition-strategy branch November 5, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant