Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Composer Implementation #44

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Initial Composer Implementation #44

merged 1 commit into from
Feb 22, 2024

Conversation

wbaldoumas
Copy link
Owner

Description

  • Move domain-specific code into BaroquenMelody.Library.Compositions.* namespace
  • Move general-purpose code into BaroquenMelody.Library.Infrastructure.* namespace
  • Implement GetInitialChord on the ICompositionStrategy which chooses an initial chord (for now just the root chord) and intelligently avoids doubling voices more than once
  • Create an IComposer interface and basic Composer implementation that uses an ICompositionStrategy to piece together a composition

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a88bde9) 97.46% compared to head (d241e76) 98.98%.
Report is 1 commits behind head on main.

Files Patch % Lines
...Library/Compositions/Extensions/MeterExtensions.cs 60.00% 1 Missing and 1 partial ⚠️
...ary/Compositions/Strategies/CompositionStrategy.cs 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   97.46%   98.98%   +1.52%     
==========================================
  Files          29       33       +4     
  Lines         474      594     +120     
  Branches       31       41      +10     
==========================================
+ Hits          462      588     +126     
+ Misses         11        3       -8     
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbaldoumas wbaldoumas marked this pull request as ready for review February 22, 2024 02:24
@wbaldoumas wbaldoumas merged commit 849b525 into main Feb 22, 2024
9 checks passed
@wbaldoumas wbaldoumas deleted the composers branch February 22, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant