Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base class of DescribeClientQuotasResponse_v0 #144

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

wbarnha
Copy link
Owner

@wbarnha wbarnha commented Mar 8, 2024

Wrong base class causes error when checking code with mypy:

kafka/protocol/admin.py:928: error: Class kafka.protocol.admin.DescribeClientQuotasResponse_v0 has abstract attributes "RESPONSE_TYPE"
kafka/protocol/admin.py:928: note: If it is meant to be abstract, add 'abc.ABCMeta' as an explicit metaclass

This change is Reviewable

@wbarnha wbarnha merged commit 65eacfb into wbarnha:master Mar 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants