Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed matchbook-types-to-matchbook-messages #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

96RadhikaJadhav
Copy link

This PR will resolve issue #20 .

Copy link
Owner

@wbjohnston wbjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you created a duplicate of matchbook-types called matchbook-messages in the packages/ directory. I'm still able to compile the project, but thats because everything is still using the old matchbook-types directory. You'll want to remove matchbook-types.

You'll also want to point all dependent services at matchbook-messages. Both the port and matching engine services are dependent. You'll be able to find the import in services/matching-engine/Cargo.toml and services/port/Cargo.toml.

Finally, matchbook-types is a member of the vscode workspace I use to develop the project. Doing a find replace in matchbook.code-workspace s/matchbook-types/matchbook-messages/ would be enough to update that file.

@wbjohnston
Copy link
Owner

If you have trouble with any of this, I'm happy to help 😃

@wbjohnston
Copy link
Owner

@96RadhikaJadhav still interested in resolving this issue?

@wbjohnston wbjohnston added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Mar 17, 2021
@wbjohnston wbjohnston linked an issue Mar 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename 'matchbook-types' to 'matchbook-messages'
2 participants