Enable timezone-aware execution timestamps #387
Merged
+101
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YS_OF_EXECUTIONS)
Tests verify: - Version < 200: date fields not encoded - Version >= 200: last_n_days and specific_dates encoded
- Mock server responses now return v200 to match advertised range - Add format spec and example to specific_dates doc
Server version 200 >= BOND_ISSUERID (176), so encoder adds issuer_id. Test helper was missing this field, causing packet mismatch with mock.
AdAstraPerAsperaMX
pushed a commit
to AdAstraPerAsperaMX/subscribe_to_group_events
that referenced
this pull request
Feb 4, 2026
* feat(orders): add `last_n_days` and `specific_dates` to `ExecutionFilter` * feat(connection): bump server `max_version` to `200` (PARAMETRIZED_DAYS_OF_EXECUTIONS) * Add tests for encode_executions version-gated date fields Tests verify: - Version < 200: date fields not encoded - Version >= 200: last_n_days and specific_dates encoded * Update mock version responses to 200, improve doc comment - Mock server responses now return v200 to match advertised range - Add format spec and example to specific_dates doc * Fix test helper to include issuer_id field for v200 Server version 200 >= BOND_ISSUERID (176), so encoder adds issuer_id. Test helper was missing this field, causing packet mismatch with mock. --------- Co-authored-by: Wil Boayue <wil.boayue@gmail.com>
AdAstraPerAsperaMX
pushed a commit
to AdAstraPerAsperaMX/subscribe_to_group_events
that referenced
this pull request
Feb 7, 2026
* feat(orders): add `last_n_days` and `specific_dates` to `ExecutionFilter` * feat(connection): bump server `max_version` to `200` (PARAMETRIZED_DAYS_OF_EXECUTIONS) * Add tests for encode_executions version-gated date fields Tests verify: - Version < 200: date fields not encoded - Version >= 200: last_n_days and specific_dates encoded * Update mock version responses to 200, improve doc comment - Mock server responses now return v200 to match advertised range - Add format spec and example to specific_dates doc * Fix test helper to include issuer_id field for v200 Server version 200 >= BOND_ISSUERID (176), so encoder adds issuer_id. Test helper was missing this field, causing packet mismatch with mock. --------- Co-authored-by: Wil Boayue <wil.boayue@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation limits the TWS server version to 173, which means execution timestamps are still returned without explicit timezone information. This forces the client to rely on the (manually set) timezone of TWS or Gateway.
Bumping to version 200 enables TWS to return timezone-aware execution timestamps (e.g., 20260130 10:46:26 America/New_York).
This also required adding two new fields to
ExecutionFilterthat TWS expects at version 200:last_n_days: filter for last N days (0 = no filter)specific_dates: filter for specific dates