feat: Add update_display_group method to clients #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement new method to update contracts in TWS display groups for both synchronous and asynchronous clients. The method allows changing the displayed contract by providing a contract identifier.
Replace client.update_display_group() with subscription.update(). DisplayGroupSubscription wraps Subscription<DisplayGroupUpdate> via Deref/DerefMut, adding only the update() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for updating the displayed contract in a TWS Display Group for both sync and async clients.
The new API allows users to:
Changes
update_display_groupto:Client(async)client::blocking::Client(sync)display_groups::asyncdisplay_groups::syncencode_update_display_group(request_id, contract_info)request_id()accessors to subscription types:Subscription<T>Subscription<T>Alignment with prior display-group work
This follows the same structure introduced in:
c551bd01ffa6c8c6a35db36d55b5d009f6d8651c2c75486b8cc908cc7da266e27288f1d54619255eSpecifically:
display_groups::{async,sync}modulesdisplay_groups/common/encoders