Add ConnectionOptions with TCP_NODELAY support #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace per-call-site env var approach with a fluent builder API. ConnectionOptions absorbs tcp_no_delay and startup_callback into a single options struct. Existing connect/connect_with_callback methods delegate to new connect_with_options on both sync and async clients. TCP_NODELAY is applied on initial connect and reconnect for both sync (TcpSocket) and async (AsyncConnection) paths.
Dedup callback-to-options conversion in 3 call sites.
Push TcpStream creation and TCP_NODELAY into Connection<TcpSocket>::connect_with_options and TcpSocket::connect, mirroring the async delegation pattern.
- All connect variants converge on init() instead of chaining - Revert connect_with_callback to Box (matching async signature) - Remove Arc dependency from sync connection
This was referenced Feb 9, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionOptionsstruct with fluent builder API (.tcp_no_delay(),.startup_callback())Client::connect_with_options(address, client_id, options)to both sync and async clientsconnect/connect_with_callbackdelegate to the new methodTCP_NODELAYapplied on initial connect and reconnect for both sync (TcpSocket) and async (AsyncConnection) pathsConnectionOptionsre-exported viaibapi::ConnectionOptionsandibapi::prelude::*Closes #390
Test plan
cargo test(default async)cargo test --no-default-features --features synccargo test --all-featurescargo clippy --features async/--features sync/--all-featurescargo fmt --check