Fix path detection algorithm #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ... 1. uses a more robust algorithm to determine special ST paths at startup, which no longer relies on location of `Default.sort` module, but uses `sys.executable` variable to determine, whether PC is running within ST plugin environment or on an external CI runner which mocks ST API. The new approach fixes an issue, which causes path detection to resolve invalid paths, if users extract whole Default package. PC assumed sublimehq's development environment in that case. 2. moves forward to rely on `__spec__` in favor of `__file__` and `__loader__` as this is what python is moving to in general. The ladder ones are dropped step by step by recent python releases (3.13).
deathaxe
force-pushed
the
fix/package-path-detection
branch
from
e88cc41
to
737bb48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path detection algorithm
This commit uses a more robust algorithm to determine ST paths at startup,
which no longer relies on
Default.sortmodule.It fixes an issue, which caused {st_dir}/Packages path detection to fail, if
Default package is extracted to {data}/Packages by end users.
To determine default package path, it first tries
sublime.executable_path(),which returns valid paths at import time on ST4088+ or with mocked ST API
in CI environments. When running on ST3,
abspath(sys.executable)is usedinstead to return plugin_host's absolute path. Without it,
sys.executableonly returns "python" on ST3's plugin_host.