Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ST4 tag series for HTML (C#) #9059

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

michaelblyons
Copy link
Contributor

@michaelblyons michaelblyons commented Feb 8, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.
    • (Will in the future)

This is just a tag series update for an existing package.

My package is unique in its support for ASP.NET WebForms.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - HTML (C#)

@braver
Copy link
Collaborator

braver commented Feb 9, 2025

First time I’ve seen “namespacing” in tags like that, are you sure that’s valid semver?

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Feb 9, 2025
@deathaxe
Copy link
Contributor

deathaxe commented Feb 9, 2025

Tag prefix can be arbitrary text, so it's technically ok.

Using / is interesting idea as it allows folding tags in Sublime Merge.

IMHO, version/ part is however redundant. I'd go with st4153/ or even just 4153/

@braver
Copy link
Collaborator

braver commented Feb 9, 2025

I thought you’d still need an hyphen (or a plus) to separate the prefix from the actual version? Didn’t make a full study of it but that’s what I got from the spec.

@deathaxe
Copy link
Contributor

deathaxe commented Feb 9, 2025

Not required. A given tag is just stripped by given tag-prefix. It can be anything. Result after stripping prefix must be a valid SemVer.

@braver
Copy link
Collaborator

braver commented Feb 9, 2025

👍🏻

@braver braver merged commit e7be1f7 into wbond:master Feb 9, 2025
2 checks passed
@michaelblyons
Copy link
Contributor Author

IMHO, version/ part is however redundant. I'd go with st4153/ or even just 4153/

🤷 I use other top-level tag namespaces for things other than versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants