Fix Job definition (#881)

* Fix Job definition * Update CHANGELOG.md * Update actions/cache to version 4 to pass CI
wbstack · Feb 24, 2025 · 483513d · 483513d
1 parent 7b1f1de
commit 483513d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/docker.build.yml b/.github/workflows/docker.build.yml
@@ -26,7 +26,7 @@ jobs:
       - name: Set up helmfile
         uses: helmfile/helmfile-action@v1.9.1
       - name: Cache Docker layers
-        uses: actions/cache@v4.0.2
+        uses: actions/cache@v4
         with:
           path: /tmp/.buildx-cache
           key: ${{ runner.os }}-buildx-${{ github.sha }}

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # api
 
+## 10x.18.4 - 19 February 2025
+- Fix job definition in UpdateWikiDailyMetricJob class
+- Update actions/cache in github workflow to version 4 to pass CI
 
 ## 10x.18.3 - 10 February 2025
 - Added new table wiki_daily_metrics

diff --git a/app/Jobs/UpdateWikiDailyMetricJob.php b/app/Jobs/UpdateWikiDailyMetricJob.php
@@ -4,15 +4,16 @@
 
 use App\Wiki;
 use \App\Metrics\App\WikiMetrics;
+use Illuminate\Contracts\Queue\ShouldBeUnique;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 
 //This job is for the daily measurements of metrics per wikibases.
 //This is to help in understanding the purpose of active wikis.
-class UpdateWikiDailyMetricJob implements ShouldQueue
+class UpdateWikiDailyMetricJob extends Job implements ShouldBeUnique
 {
     use Dispatchable;
-    public int $timeout = 3600;
+    public $timeout = 3600;
 
     /**
      * Execute the job.