refactor: fail late when bulk creating entities

wbstack · Aug 6, 2024 · 9da79ce · 9da79ce
1 parent 9a6ce98
commit 9da79ce
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/repo.js b/lib/repo.js
@@ -29,9 +29,17 @@ export default class WikibaseRepository {
     if (!this.edit) {
       return Promise.reject(new Error('Cannot edit a read only instance.'))
     }
-    return Promise.all(entities.map(async entity => {
+    return Promise.allSettled(entities.map(async entity => {
       return this.edit.entity.create(entity)
     }))
+      .then((results) => {
+        for (const result of results) {
+          if (result.status === 'rejected') {
+            throw new Error(result.reason)
+          }
+        }
+        return results.map(v => v.value)
+      })
   }
 
   getEntities (...identifiers) {