Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace Models #137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Namespace Models #137

wants to merge 3 commits into from

Conversation

wcadena
Copy link
Owner

@wcadena wcadena commented Dec 3, 2019

This pull request includes changes for namespacing models under App\Models. Feel free to commit any additional changes to the shift-20985 branch.

Before merging, you need to:

  • Checkout the shift-20985 branch
  • Review all pull request comments for additional changes
  • Thoroughly test your application

@laravel-shift
Adopt Laravel coding style
00c2644 
The Laravel framework adopts the PSR-2 coding style with some additions.
Laravel apps *should* adopt this coding style as well.

However, Shift allows you to customize the adopted coding style by
adding your own [PHP CS Fixer][1] `.php_cs` config to your project.

You may use [Shift's .php_cs][2] file as a base.

[1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer
[2]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
@laravel-shift
Shift bindings
b180f12 
Laravel 5.1 requires PHP 5.5.9+ which provides the new static `class`
property to get the fully qualified name of a class and is preferred
over using class name strings.
@laravel-shift
Namespace models under App\Models
363c3c8
@wcadena
Copy link
Owner Author

wcadena commented Dec 3, 2019

⚠️ While Shift updated model references within your application code, you may reference models outside the code. Be sure to review your environment configuration, database, and queues for additional references.

@wcadena
Copy link
Owner Author

wcadena commented Dec 3, 2019

⚠️ Shift detected polymorphic relationships within your application. Unless you created custom polymorphic types using morphMap, you will need to update the fully qualified names in the related model table.

Shift found potential instances of polymorphic relationships in:

  • app/Models/FileEntry.php
  • app/Models/InformeMantenimientoPreventivo.php

Base automatically changed from desarrollo_version3 to master November 4, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcadena @laravel-shift