Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically generate X-VHost header #93

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Dynamically generate X-VHost header #93

merged 6 commits into from
Oct 14, 2024

Conversation

twolfart
Copy link
Contributor

@twolfart twolfart commented Oct 4, 2024

Generate the value of the debugging header X-Vhost with discriminable values.

@tobias-richter
Copy link
Contributor

@stefanseifert if you have no objections we can merge this PR.

stefanseifert
stefanseifert approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (i've not actually tested it)

@twolfart
Copy link
Contributor Author

lgtm (i've not actually tested it)

Example render for role: aem-dispatcher-ams

  # Add header breadcrumbs for help in troubleshooting
<IfDefine ENVIRONMENT_DEV>
  Header add X-Vhost "some dev domain"
</IfDefine>
<IfDefine ENVIRONMENT_STAGE>
  Header add X-Vhost "some stage domain"
</IfDefine>
<IfDefine ENVIRONMENT_PROD>
  Header add X-Vhost "some prod domain"
</IfDefine>

@tobias-richter tobias-richter merged commit aecfb37 into wcm-io-devops:develop Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-richter tobias-richter tobias-richter approved these changes

@stefanseifert stefanseifert stefanseifert approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twolfart @tobias-richter @stefanseifert