Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require keyword args in models #163

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Require keyword args in models #163

merged 4 commits into from
Oct 27, 2024

Conversation

wd60622
Copy link
Owner

@wd60622 wd60622 commented Oct 27, 2024

Require keyword arguments in all models

TODO:

  • Search the documentation for any models that are missing required keyword arguments

@wd60622 wd60622 linked an issue Oct 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (14e6035) to head (eec1f2c).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   95.99%   95.96%   -0.04%     
==========================================
  Files           7        7              
  Lines         949      941       -8     
==========================================
- Hits          911      903       -8     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added enhancement New feature or request models Has to do with the models predictive labels Oct 27, 2024
@wd60622 wd60622 changed the title Require keyword args Require keyword args in models Oct 27, 2024
@wd60622 wd60622 merged commit 28ee514 into main Oct 27, 2024
17 checks passed
@wd60622 wd60622 deleted the 100-use-of-keyword-args-only branch October 27, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request models Has to do with the models predictive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of keyword args in models
1 participant