Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxDistance as an input parameter #134

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

lyfsn
Copy link
Contributor

@lyfsn lyfsn commented Apr 11, 2024

No description provided.

Signed-off-by: lyfsn <dev.wangyu@proton.me>
@mcdee
Copy link
Collaborator

mcdee commented Apr 28, 2024

Thanks for this PR. It appears that it is causing some failures in tests, please could you take a look at these?

Signed-off-by: lyfsn <dev.wangyu@proton.me>
@lyfsn
Copy link
Contributor Author

lyfsn commented Apr 29, 2024

@mcdee
Hey, some failures in tests were caused by the maxDistance default value problem. If user use the command line normally, the default value will be bound to 1024 by the environment variable https://github.com/wealdtech/ethdo/pull/134/files#diff-6f22dfa39a49962182a03b04b7d994b24a9e2ed446d37ad812c5499aa8c33fe0R67 , but in unit tests, the default value in the environment variable does not work.

So, I changed the maxDistance default value in the process function, retaining the original 1024, and if a user passes the --maxDistance parameter, the parameter will override the default 1024.

There should be no failures in tests now.

@mcdee
Copy link
Collaborator

mcdee commented Apr 29, 2024

Looking good, thanks for the changes.

@mcdee mcdee merged commit 7e09068 into wealdtech:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants