Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: partner content update #427

Merged
merged 4 commits into from
May 23, 2024
Merged

chore: partner content update #427

merged 4 commits into from
May 23, 2024

Conversation

JoeKarow
Copy link
Member

@JoeKarow JoeKarow commented May 23, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): Content

Summary by CodeRabbit

  • New Features

    • Added a new section for supporting funders on the About page.
    • Updated partner links and images on the About page for improved visibility and layout.
  • Bug Fixes

    • Corrected links and text in the "about" section of the English and Spanish locales to ensure proper rendering and functionality.
  • Style

    • Adjusted styling for partner images to ensure responsive design across different screen sizes.
  • Chores

    • Updated dependencies to include i18next-hmr for hot module replacement in translation files.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
transmascfutures ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 6:35pm

Copy link

deepsource-io bot commented May 23, 2024

Here's the code health analysis summary for commits f9395c1..5086318. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 2 occurences introduced
🎯 12 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@JoeKarow JoeKarow added automerge Enable Kodiak auto-merge maintenance Generic maintenance tasks. labels May 23, 2024
Copy link

coderabbitai bot commented May 23, 2024

Walkthrough

The project updates focus on enhancing the internationalization (i18n) setup and refining the user experience on the "About" page. Key changes include adding plugins for i18n based on the environment, updating partner images and links, and improving the layout and content for supporting partners and funders. Additionally, new dependencies were introduced, and configuration files were updated to support these enhancements.

Changes

File Path Change Summary
next-i18next.config.js Introduced a plugins function to conditionally add plugins based on the environment.
next.config.mjs Added imports for path and fileURLToPath, renamed config to nextConfig, and included I18NextHMRPlugin.
package.json Added "i18next-hmr": "3.1.2" to dependencies.
public/locales/en/common.json Updated "about" section links, added "supporting-funders" key, and adjusted the "thank-you" message.
public/locales/es/common.json Updated "about" section links with attributes, added "supporting-funders" key.
src/data/partners.ts Added Lush partner image and reordered partner images.
src/pages/about.tsx Imported Link from 'next/link', adjusted styling for partnerHollister, updated partner links rendering logic, and modified layout and content for supporting partners and funders sections.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

socket-security bot commented May 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/i18next-hmr@3.1.2 None 0 43.9 kB felixmosh

View full report↗︎

Copy link

relativeci bot commented May 23, 2024

#92 Bundle Size — 18.74MiB (+0.38%).

5086318(current) vs c38056d dev#79(baseline)

Bundle metrics  Change 5 changes Regression 1 regression
                 Current
#92
     Baseline
#79
Regression  Initial JS 1008.18KiB(+0.04%) 1007.8KiB
No change  Initial CSS 6.61KiB 6.61KiB
Change  Cache Invalidation 2.3% 2.36%
No change  Chunks 20 20
Change  Assets 80(+1.27%) 79
Change  Modules 790(+0.13%) 789
No change  Duplicate Modules 103 103
Change  Duplicate Code 5.61%(-0.18%) 5.62%
No change  Packages 81 81
No change  Duplicate Packages 0 0
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#92
     Baseline
#79
Regression  IMG 17.47MiB (+0.41%) 17.4MiB
Regression  JS 1.08MiB (+0.03%) 1.08MiB
No change  Fonts 189.64KiB 189.64KiB
No change  CSS 6.61KiB 6.61KiB
No change  Other 4.06KiB 4.06KiB

Bundle analysis reportBranch JoeKarow/partner-updateProject dashboard

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f9395c1 and 5086318.
Files ignored due to path filters (2)
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
  • public/assets/partners/lush.png is excluded by !**/*.png
Files selected for processing (7)
  • next-i18next.config.js (2 hunks)
  • next.config.mjs (3 hunks)
  • package.json (1 hunks)
  • public/locales/en/common.json (3 hunks)
  • public/locales/es/common.json (3 hunks)
  • src/data/partners.ts (2 hunks)
  • src/pages/about.tsx (5 hunks)
Files skipped from review due to trivial changes (2)
  • package.json
  • public/locales/en/common.json
Additional Context Used
Biome (4)
next-i18next.config.js (1)

6-6: A Node.js builtin module should be imported with the node: protocol.

src/data/partners.ts (1)

2-2: All these imports are only used as types.

src/pages/about.tsx (2)

18-18: All these imports are only used as types.


null-null: Import statements could be sorted:

Additional comments not posted (9)
src/data/partners.ts (2)

8-8: The import for the Lush partner image is correctly added and used.


19-26: The reordering and addition of partner images in the partnerImages object is correctly implemented.

next-i18next.config.js (2)

8-23: The plugins function is correctly implemented to conditionally add plugins based on the environment.


45-45: The integration of the plugins function into the use property of the config object is correctly done.

next.config.mjs (2)

5-10: The imports and constants definitions are correctly implemented.

Also applies to: 19-20


Line range hint 27-56: The updates to the webpack configuration, including the conditional inclusion of plugins, are correctly implemented.

src/pages/about.tsx (2)

20-20: The import of Link from 'next/link' is correctly added for enhanced link handling.


Line range hint 78-199: The updates to the rendering logic for partner links, including the use of the Grid component and conditional rendering based on the presence of partners, are correctly implemented.

public/locales/es/common.json (1)

Line range hint 3-13: The updates to the "about" section, including the addition of new keys and updated links, are correctly implemented.

next-i18next.config.js Show resolved Hide resolved
@JoeKarow JoeKarow requested a review from InReach-svc May 23, 2024 18:39
@kodiakhq kodiakhq bot merged commit 72dd620 into dev May 23, 2024
21 of 23 checks passed
@kodiakhq kodiakhq bot deleted the JoeKarow/partner-update branch May 23, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Enable Kodiak auto-merge maintenance Generic maintenance tasks.
Development

Successfully merging this pull request may close these issues.

2 participants