-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: partner content update #427
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Here's the code health analysis summary for commits Analysis Summary
|
WalkthroughThe project updates focus on enhancing the internationalization (i18n) setup and refining the user experience on the "About" page. Key changes include adding plugins for i18n based on the environment, updating partner images and links, and improving the layout and content for supporting partners and funders. Additionally, new dependencies were introduced, and configuration files were updated to support these enhancements. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
#92 Bundle Size — 18.74MiB (+0.38%).Bundle metrics
|
Current #92 |
Baseline #79 |
|
---|---|---|
Initial JS | 1008.18KiB (+0.04% ) |
1007.8KiB |
Initial CSS | 6.61KiB |
6.61KiB |
Cache Invalidation | 2.3% |
2.36% |
Chunks | 20 |
20 |
Assets | 80 (+1.27% ) |
79 |
Modules | 790 (+0.13% ) |
789 |
Duplicate Modules | 103 |
103 |
Duplicate Code | 5.61% (-0.18% ) |
5.62% |
Packages | 81 |
81 |
Duplicate Packages | 0 |
0 |
Bundle size by type 2 changes
2 regressions
Current #92 |
Baseline #79 |
|
---|---|---|
IMG | 17.47MiB (+0.41% ) |
17.4MiB |
JS | 1.08MiB (+0.03% ) |
1.08MiB |
Fonts | 189.64KiB |
189.64KiB |
CSS | 6.61KiB |
6.61KiB |
Other | 4.06KiB |
4.06KiB |
Bundle analysis report Branch JoeKarow/partner-update Project dashboard
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
pnpm-lock.yaml
is excluded by!pnpm-lock.yaml
public/assets/partners/lush.png
is excluded by!**/*.png
Files selected for processing (7)
- next-i18next.config.js (2 hunks)
- next.config.mjs (3 hunks)
- package.json (1 hunks)
- public/locales/en/common.json (3 hunks)
- public/locales/es/common.json (3 hunks)
- src/data/partners.ts (2 hunks)
- src/pages/about.tsx (5 hunks)
Files skipped from review due to trivial changes (2)
- package.json
- public/locales/en/common.json
Additional Context Used
Biome (4)
next-i18next.config.js (1)
6-6: A Node.js builtin module should be imported with the node: protocol.
src/data/partners.ts (1)
2-2: All these imports are only used as types.
src/pages/about.tsx (2)
18-18: All these imports are only used as types.
null-null: Import statements could be sorted:
Additional comments not posted (9)
src/data/partners.ts (2)
8-8
: The import for the Lush partner image is correctly added and used.
19-26
: The reordering and addition of partner images in thepartnerImages
object is correctly implemented.next-i18next.config.js (2)
8-23
: Theplugins
function is correctly implemented to conditionally add plugins based on the environment.
45-45
: The integration of theplugins
function into theuse
property of the config object is correctly done.next.config.mjs (2)
5-10
: The imports and constants definitions are correctly implemented.Also applies to: 19-20
Line range hint
27-56
: The updates to the webpack configuration, including the conditional inclusion of plugins, are correctly implemented.src/pages/about.tsx (2)
20-20
: The import ofLink
from 'next/link' is correctly added for enhanced link handling.
Line range hint
78-199
: The updates to the rendering logic for partner links, including the use of theGrid
component and conditional rendering based on the presence of partners, are correctly implemented.public/locales/es/common.json (1)
Line range hint
3-13
: The updates to the "about" section, including the addition of new keys and updated links, are correctly implemented.
Pull Request type
Please check the type of change your PR introduces:
Summary by CodeRabbit
New Features
Bug Fixes
Style
Chores
i18next-hmr
for hot module replacement in translation files.