Update Byline Design #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates byline according to the design here:
https://www.figma.com/design/MX0AcO8d0ZlCBs4e9vkl5f/PSI-Design-System?node-id=1102-2973&node-type=canvas&t=lMi5QZ4jNrhUGlmy-0
Three variants: Large, Small, Tiny
All metadata shows on the second line
Metadata row is toggleable
Confirmed with Tori these are desired sizes configurations for ByLines across the app:
Comment preview (ie your current response): Small
Immediately above the composer: Large
Question Author byline: large
Top post in Comment thread - large
Reply in comment thread - small
Reply to a reply in a comment thread - tiny
Comment reply composer - small (no metadata shown)
Top Bar: small (no metadata shown)
Teaser comment preview: small