chore: refactor code, add timeouts on operations

weaveVM · Nov 13, 2024 · c93dc36 · c93dc36
1 parent 14a0e2b
commit c93dc36
Show file tree

Hide file tree

Showing 5 changed files with 151 additions and 225 deletions.
diff --git a/.env.example.holesky b/.env.example.holesky
@@ -99,6 +99,9 @@ EIGENDA_PROXY_EIGENDA_SERVICE_MANAGER_ADDR=0xD4A7E1Bd8015057293f0D0A557088c28694
 # WVM chain id
 # EIGENDA_PROXY_WVM_CHAIN_ID=9496
 
+# WVM operations timeout
+# EIGENDA_PROXY_WVM_TIMEOUT=5s
+
 # WVM web3signer endpoint
 # EIGENDA_PROXY_WVM_WEB3_SIGNER_ENDPOINT=
 

diff --git a/store/precomputed_key/wvm/cli.go b/store/precomputed_key/wvm/cli.go
@@ -1,6 +1,8 @@
 package wvm
 
 import (
+	"time"
+
 	"github.com/urfave/cli/v2"
 )
 
@@ -56,13 +58,13 @@ func CLIFlags(envPrefix, category string) []cli.Flag {
 			EnvVars:  withEnvPrefix(envPrefix, "WEB3_SIGNER_ENDPOINT"),
 			Category: category,
 		},
-		// &cli.DurationFlag{
-		// 	Name:     TimeoutFlagName,
-		// 	Usage:    "timeout for S3 storage operations (e.g. get, put)",
-		// 	Value:    5 * time.Second,
-		// 	EnvVars:  withEnvPrefix(envPrefix, "TIMEOUT"),
-		// 	Category: category,
-		// },
+		&cli.DurationFlag{
+			Name:     TimeoutFlagName,
+			Usage:    "timeout for WVM requests operations (e.g. get, put)",
+			Value:    5 * time.Second,
+			EnvVars:  withEnvPrefix(envPrefix, "TIMEOUT"),
+			Category: category,
+		},
 	}
 }
 
@@ -73,6 +75,6 @@ func ReadConfig(ctx *cli.Context) Config {
 		ArchiverAddress:    ctx.String(ArchiverAddressFlagName),
 		Web3SignerEndpoint: ctx.String(Web3SignerEndpoint),
 		Enabled:            ctx.Bool(EnabledFlagName),
-		// Timeout:         ctx.Duration(TimeoutFlagName),
+		Timeout:            ctx.Duration(TimeoutFlagName),
 	}
 }