clean pull request ssh references as not supported #47 (#166)

weaveworks · Feb 24, 2023 · 3251ede · 3251ede
1 parent 5c48516
commit 3251ede
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 26 deletions.
diff --git a/api/v1alpha1/pipeline_types.go b/api/v1alpha1/pipeline_types.go
@@ -109,7 +109,7 @@ type PullRequestPromotion struct {
 	// +required
 	// +kubebuilder:validation:Enum=github;gitlab;bitbucket-server
 	Type GitProviderType `json:"type"`
-	// The git repository URL used to patch the manifests for promotion.
+	// The git repository HTTPS URL used to patch the manifests for promotion.
 	// +required
 	URL string `json:"url"`
 	// The branch to checkout after cloning. Note: This is just the base
@@ -126,8 +126,6 @@ type PullRequestPromotion struct {
 	// the git repository and for the git provider API.
 	// For HTTPS repositories the Secret must contain 'username' and 'password'
 	// fields.
-	// For SSH repositories the Secret must contain 'identity'
-	// and 'known_hosts' fields.
 	// For Git Provider API to manage pull requests, it must contain a 'token' field.
 	// +required
 	SecretRef meta.LocalObjectReference `json:"secretRef"`

diff --git a/charts/pipeline-controller/Chart.yaml b/charts/pipeline-controller/Chart.yaml
@@ -2,5 +2,5 @@ apiVersion: v2
 name: pipeline-controller
 description: Pipeline-controller Helm chart for Weave GitOps Enterprise
 type: application
-version: 0.17.0
+version: 0.18.0
 appVersion: "v0.0.29"
diff --git a/charts/pipeline-controller/crds/pipelines.weave.works_pipelines.yaml b/charts/pipeline-controller/crds/pipelines.weave.works_pipelines.yaml
@@ -116,10 +116,8 @@ spec:
                                     authentication credentials for the git repository
                                     and for the git provider API. For HTTPS repositories
                                     the Secret must contain 'username' and 'password'
-                                    fields. For SSH repositories the Secret must contain
-                                    'identity' and 'known_hosts' fields. For Git Provider
-                                    API to manage pull requests, it must contain a
-                                    'token' field.
+                                    fields. For Git Provider API to manage pull requests,
+                                    it must contain a 'token' field.
                                   properties:
                                     name:
                                       description: Name of the referent.
@@ -136,8 +134,8 @@ spec:
                                   - bitbucket-server
                                   type: string
                                 url:
-                                  description: The git repository URL used to patch
-                                    the manifests for promotion.
+                                  description: The git repository HTTPS URL used to
+                                    patch the manifests for promotion.
                                   type: string
                               required:
                               - secretRef
@@ -241,9 +239,8 @@ spec:
                               authentication credentials for the git repository and
                               for the git provider API. For HTTPS repositories the
                               Secret must contain 'username' and 'password' fields.
-                              For SSH repositories the Secret must contain 'identity'
-                              and 'known_hosts' fields. For Git Provider API to manage
-                              pull requests, it must contain a 'token' field.
+                              For Git Provider API to manage pull requests, it must
+                              contain a 'token' field.
                             properties:
                               name:
                                 description: Name of the referent.
@@ -260,8 +257,8 @@ spec:
                             - bitbucket-server
                             type: string
                           url:
-                            description: The git repository URL used to patch the
-                              manifests for promotion.
+                            description: The git repository HTTPS URL used to patch
+                              the manifests for promotion.
                             type: string
                         required:
                         - secretRef

diff --git a/config/crd/bases/pipelines.weave.works_pipelines.yaml b/config/crd/bases/pipelines.weave.works_pipelines.yaml
@@ -116,10 +116,8 @@ spec:
                                     authentication credentials for the git repository
                                     and for the git provider API. For HTTPS repositories
                                     the Secret must contain 'username' and 'password'
-                                    fields. For SSH repositories the Secret must contain
-                                    'identity' and 'known_hosts' fields. For Git Provider
-                                    API to manage pull requests, it must contain a
-                                    'token' field.
+                                    fields. For Git Provider API to manage pull requests,
+                                    it must contain a 'token' field.
                                   properties:
                                     name:
                                       description: Name of the referent.
@@ -136,8 +134,8 @@ spec:
                                   - bitbucket-server
                                   type: string
                                 url:
-                                  description: The git repository URL used to patch
-                                    the manifests for promotion.
+                                  description: The git repository HTTPS URL used to
+                                    patch the manifests for promotion.
                                   type: string
                               required:
                               - secretRef
@@ -241,9 +239,8 @@ spec:
                               authentication credentials for the git repository and
                               for the git provider API. For HTTPS repositories the
                               Secret must contain 'username' and 'password' fields.
-                              For SSH repositories the Secret must contain 'identity'
-                              and 'known_hosts' fields. For Git Provider API to manage
-                              pull requests, it must contain a 'token' field.
+                              For Git Provider API to manage pull requests, it must
+                              contain a 'token' field.
                             properties:
                               name:
                                 description: Name of the referent.
@@ -260,8 +257,8 @@ spec:
                             - bitbucket-server
                             type: string
                           url:
-                            description: The git repository URL used to patch the
-                              manifests for promotion.
+                            description: The git repository HTTPS URL used to patch
+                              the manifests for promotion.
                             type: string
                         required:
                         - secretRef