Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean pull request ssh references as not supported https://github.com… #166

Merged
merged 1 commit into from
Feb 24, 2023
Merged

clean pull request ssh references as not supported https://github.com… #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api/v1alpha1/pipeline_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ type PullRequestPromotion struct {
// +required
// +kubebuilder:validation:Enum=github;gitlab;bitbucket-server
Type GitProviderType `json:"type"`
// The git repository URL used to patch the manifests for promotion.
// The git repository HTTPS URL used to patch the manifests for promotion.
// +required
URL string `json:"url"`
// The branch to checkout after cloning. Note: This is just the base
Expand All @@ -126,8 +126,6 @@ type PullRequestPromotion struct {
// the git repository and for the git provider API.
// For HTTPS repositories the Secret must contain 'username' and 'password'
// fields.
// For SSH repositories the Secret must contain 'identity'
// and 'known_hosts' fields.
// For Git Provider API to manage pull requests, it must contain a 'token' field.
// +required
SecretRef meta.LocalObjectReference `json:"secretRef"`
Expand Down
2 changes: 1 addition & 1 deletion charts/pipeline-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: pipeline-controller
description: Pipeline-controller Helm chart for Weave GitOps Enterprise
type: application
version: 0.17.0
version: 0.18.0
appVersion: "v0.0.29"
19 changes: 8 additions & 11 deletions charts/pipeline-controller/crds/pipelines.weave.works_pipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,8 @@ spec:
authentication credentials for the git repository
and for the git provider API. For HTTPS repositories
the Secret must contain 'username' and 'password'
fields. For SSH repositories the Secret must contain
'identity' and 'known_hosts' fields. For Git Provider
API to manage pull requests, it must contain a
'token' field.
fields. For Git Provider API to manage pull requests,
it must contain a 'token' field.
properties:
name:
description: Name of the referent.
Expand All @@ -136,8 +134,8 @@ spec:
- bitbucket-server
type: string
url:
description: The git repository URL used to patch
the manifests for promotion.
description: The git repository HTTPS URL used to
patch the manifests for promotion.
type: string
required:
- secretRef
Expand Down Expand Up @@ -241,9 +239,8 @@ spec:
authentication credentials for the git repository and
for the git provider API. For HTTPS repositories the
Secret must contain 'username' and 'password' fields.
For SSH repositories the Secret must contain 'identity'
and 'known_hosts' fields. For Git Provider API to manage
pull requests, it must contain a 'token' field.
For Git Provider API to manage pull requests, it must
contain a 'token' field.
properties:
name:
description: Name of the referent.
Expand All @@ -260,8 +257,8 @@ spec:
- bitbucket-server
type: string
url:
description: The git repository URL used to patch the
manifests for promotion.
description: The git repository HTTPS URL used to patch
the manifests for promotion.
type: string
required:
- secretRef
Expand Down
19 changes: 8 additions & 11 deletions config/crd/bases/pipelines.weave.works_pipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,8 @@ spec:
authentication credentials for the git repository
and for the git provider API. For HTTPS repositories
the Secret must contain 'username' and 'password'
fields. For SSH repositories the Secret must contain
'identity' and 'known_hosts' fields. For Git Provider
API to manage pull requests, it must contain a
'token' field.
fields. For Git Provider API to manage pull requests,
it must contain a 'token' field.
properties:
name:
description: Name of the referent.
Expand All @@ -136,8 +134,8 @@ spec:
- bitbucket-server
type: string
url:
description: The git repository URL used to patch
the manifests for promotion.
description: The git repository HTTPS URL used to
patch the manifests for promotion.
type: string
required:
- secretRef
Expand Down Expand Up @@ -241,9 +239,8 @@ spec:
authentication credentials for the git repository and
for the git provider API. For HTTPS repositories the
Secret must contain 'username' and 'password' fields.
For SSH repositories the Secret must contain 'identity'
and 'known_hosts' fields. For Git Provider API to manage
pull requests, it must contain a 'token' field.
For Git Provider API to manage pull requests, it must
contain a 'token' field.
properties:
name:
description: Name of the referent.
Expand All @@ -260,8 +257,8 @@ spec:
- bitbucket-server
type: string
url:
description: The git repository URL used to patch the
manifests for promotion.
description: The git repository HTTPS URL used to patch
the manifests for promotion.
type: string
required:
- secretRef
Expand Down