Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring hostAliases of Weaviate pod #206

Merged

Conversation

andrewisplinghoff
Copy link
Contributor

hostAliases allows you to perform hostname resolution when DNS is not available (see https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/). In my case, this is required to reach an Azure OpenAI deployment via a private endpoint (DNS not available, and correct hostname still has to be used so that certificate validation can succeed).

Previously, it was not possible to configure this setting when using the Weaviate helm chart, this PR allows the user to add a configuration of the hostAliases used for the Weaviate pod.

Note that this PR does not add this setting to other pods than the Weaviate pod. For my current use case, that is sufficient, but maybe it still would be desirable to have it applied also to other pods (maybe same behaviour as nodeSelector/tolerations/affinity with a global + module level config).

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@andrewisplinghoff
Copy link
Contributor Author

I agree with the CLA.

@antas-marcin antas-marcin merged commit 07a1d99 into weaviate:master Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants