refactor(plugin-preact): modify rsbuild config directly (#1743)

packages/plugin-preact/package.json

@@ -30,7 +30,6 @@
   },
   "devDependencies": {
     "@rsbuild/core": "workspace:*",
-    "@scripts/test-helper": "workspace:*",
     "@types/node": "16.x",
     "typescript": "^5.3.0"
   },

packages/plugin-preact/src/index.ts

@@ -1,5 +1,5 @@
-import type { RsbuildPlugin } from '@rsbuild/core';
-import { modifySwcLoaderOptions, type SwcReactConfig } from '@rsbuild/shared';
+import type { RsbuildConfig, RsbuildPlugin } from '@rsbuild/core';
+import { getNodeEnv, type SwcReactConfig } from '@rsbuild/shared';
 
 export type PluginPreactOptions = {
   /**
@@ -17,34 +17,38 @@ export const pluginPreact = (
   setup(api) {
     const { reactAliasesEnabled = true } = options;
 
-    api.modifyBundlerChain(async (chain, { isDev }) => {
+    api.modifyRsbuildConfig((userConfig, { mergeRsbuildConfig }) => {
+      const reactOptions: SwcReactConfig = {
+        development: getNodeEnv() === 'development',
+        runtime: 'automatic',
+        importSource: 'preact',
+      };
+
+      const extraConfig: RsbuildConfig = {
+        tools: {
+          swc(opts) {
+            opts.jsc ??= {};
+            opts.jsc.transform ??= {};
+            opts.jsc.transform.react = {
+              ...opts.jsc.transform.react,
+              ...reactOptions,
+            };
+            return opts;
+          },
+        },
+      };
+
       if (reactAliasesEnabled) {
-        chain.resolve.alias.merge({
+        extraConfig.source ||= {};
+        extraConfig.source.alias = {
           react: 'preact/compat',
           'react-dom/test-utils': 'preact/test-utils',
           'react-dom': 'preact/compat',
           'react/jsx-runtime': 'preact/jsx-runtime',
-        });
+        };
       }
 
-      const reactOptions: SwcReactConfig = {
-        development: isDev,
-        runtime: 'automatic',
-        importSource: 'preact',
-      };
-
-      modifySwcLoaderOptions({
-        chain,
-        modifier: (opts) => {
-          opts.jsc ??= {};
-          opts.jsc.transform ??= {};
-          opts.jsc.transform.react = {
-            ...opts.jsc.transform.react,
-            ...reactOptions,
-          };
-          return opts;
-        },
-      });
+      return mergeRsbuildConfig(extraConfig, userConfig);
     });
   },
 });

packages/plugin-preact/tests/index.test.ts

@@ -1,34 +1,38 @@
-import { expect, describe, it, vi } from 'vitest';
+import { expect, describe, it } from 'vitest';
 import { pluginPreact } from '../src';
-import { createStubRsbuild } from '@scripts/test-helper';
+import { createRsbuild } from '@rsbuild/core';
 
 describe('plugins/preact', () => {
+  const preactAlias = {
+    react: 'preact/compat',
+    'react-dom': 'preact/compat',
+    'react-dom/test-utils': 'preact/test-utils',
+    'react/jsx-runtime': 'preact/jsx-runtime',
+  };
+
   it('should apply react aliases by default', async () => {
-    const rsbuild = await createStubRsbuild({
-      plugins: [pluginPreact()],
+    const rsbuild = await createRsbuild({
+      rsbuildConfig: {
+        plugins: [pluginPreact()],
+      },
     });
 
-    const config = await rsbuild.unwrapConfig();
-    expect(config.resolve.alias).toMatchInlineSnapshot(`
-      {
-        "react": "preact/compat",
-        "react-dom": "preact/compat",
-        "react-dom/test-utils": "preact/test-utils",
-        "react/jsx-runtime": "preact/jsx-runtime",
-      }
-    `);
+    const configs = await rsbuild.initConfigs();
+    expect(configs[0].resolve?.alias).toMatchObject(preactAlias);
   });
 
   it('should not apply react aliases if reactAliasesEnabled is false', async () => {
-    const rsbuild = await createStubRsbuild({
-      plugins: [
-        pluginPreact({
-          reactAliasesEnabled: false,
-        }),
-      ],
+    const rsbuild = await createRsbuild({
+      rsbuildConfig: {
+        plugins: [
+          pluginPreact({
+            reactAliasesEnabled: false,
+          }),
+        ],
+      },
     });
 
-    const config = await rsbuild.unwrapConfig();
-    expect(config.resolve?.alias).toBeFalsy();
+    const configs = await rsbuild.initConfigs();
+    expect(configs[0].resolve?.alias).not.toMatchObject(preactAlias);
   });
 });