fix: do not open browser when open parameter is set to false #4291
Conversation
|
|
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const { open } = config.server; | ||
|
|
||
| if (typeof open === 'boolean') { | ||
| return { targets: [] }; | ||
| return { targets: [], skip: !open }; |
There was a problem hiding this comment.
This doesn't seem necessary, the server plugin already checks if open is false:
https://github.com/web-infra-dev/rsbuild/blob/main/packages/core/src/plugins/server.ts#L15
There was a problem hiding this comment.
Then there must be something else wrong as
import { defineConfig } from '@rsbuild/core';
import { pluginReact } from '@rsbuild/plugin-react';
export default defineConfig({
plugins: [pluginReact()],
server: {
open: false,
},
});still opens the browser after the server started.
i am using "@rsbuild/core": "^1.1.13"
There was a problem hiding this comment.
Are you using the --open CLI flag? The CLI flag takes precedence over the configurations,
There was a problem hiding this comment.
oh no, it is part of the package dev script. thanks. sorry for the confusion. will close it.
Summary
Allows to disable browser opening by setting the open parameter to false.
Related Links
Checklist