Move to ES Modules #147
Open
Move to ES Modules #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
web-mech
requested changes
Jan 5, 2023
Owner
web-mech
left a comment
web-mech
left a comment
There was a problem hiding this comment.
I think it's fine to support ESM here without needing to support both ESM + CJS. But this will need to be a part of a major release. We should also update the dependencies being required here.
|
Any update on this? |
Author
|
As far as I know, this branch is working and I'm not sure what the timeline is on being merged. I'll go through and make the dependencies use ESM import though to resolve the changes requested by @web-mech . |
Author
|
Just moved everything over to ESM in this PR! |
|
Fantastic, thanks for that @reesericci! I'll keep an eye out on the next release |
Owner
|
Thanks @reesericci , will see if we can merge this in soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for use as an ESM module with the following syntax:
import Filter from 'badwords'