Skip to content

Commit

Permalink
[WebDriver BiDi] Fix timing info assert to match spec (#47287)
Browse files Browse the repository at this point in the history
* [WebDriver BiDi] Fix timing info assert to match spec

* revert: formatting
  • Loading branch information
Lightning00Blade authored Jul 25, 2024
1 parent e127081 commit d5d125a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 13 deletions.
4 changes: 4 additions & 0 deletions webdriver/tests/bidi/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ def any_int(actual: Any) -> None:
assert isinstance(actual, int)


def any_number(actual: Any) -> None:
assert isinstance(actual, int) or isinstance(actual, float)


def any_int_or_null(actual: Any) -> None:
if actual is not None:
any_int(actual)
Expand Down
27 changes: 14 additions & 13 deletions webdriver/tests/bidi/network/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
any_bool,
any_dict,
any_int,
any_number,
any_int_or_null,
any_list,
any_string,
Expand All @@ -27,19 +28,19 @@ def assert_headers(event_headers, expected_headers):
def assert_timing_info(timing_info):
recursive_compare(
{
"timeOrigin": any_int,
"requestTime": any_int,
"redirectStart": any_int,
"redirectEnd": any_int,
"fetchStart": any_int,
"dnsStart": any_int,
"dnsEnd": any_int,
"connectStart": any_int,
"connectEnd": any_int,
"tlsStart": any_int,
"requestStart": any_int,
"responseStart": any_int,
"responseEnd": any_int,
"timeOrigin": any_number,
"requestTime": any_number,
"redirectStart": any_number,
"redirectEnd": any_number,
"fetchStart": any_number,
"dnsStart": any_number,
"dnsEnd": any_number,
"connectStart": any_number,
"connectEnd": any_number,
"tlsStart": any_number,
"requestStart": any_number,
"responseStart": any_number,
"responseEnd": any_number,
},
timing_info,
)
Expand Down

0 comments on commit d5d125a

Please sign in to comment.