-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[wptrunner] Stop the runner process before the browser (#48030)
... via a `stop` message that tells the runner to gracefully tear down the protocol. * For WebDriver-based executors, this will close the session appropriately [1]. * For `chromedriver` in particular, this will ensure some per-session `/tmp/.org.chromium.Chromium.*` temporary directories [2], which are currently leaked, are deleted. Also, remove the redundant `runner_teardown` command from the runner to main process. [1]: https://www.w3.org/TR/webdriver/#delete-session [2]: https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/chrome/chrome_desktop_impl.cc;l=107-122;drc=b14c93608871784e41d6d40f1c5952cf24aa39db;bpv=0;bpt=0
- Loading branch information
1 parent
437f131
commit d65cf80
Showing
2 changed files
with
18 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters