fixup! Trigger Safari & Safari Technology Preview runs after epochs

web-platform-tests · Sep 11, 2024 · fbc3a9e · fbc3a9e
1 parent da64fdf
commit fbc3a9e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.github/workflows/safari_stable.yml b/.github/workflows/safari_stable.yml
@@ -34,6 +34,9 @@ jobs:
     name: "All Tests: Safari (stable)"
     needs: check-workflow-run
     if: |
+      # We need always() here to then check for success/skipped from the dependency, as otherwise
+      # the skip cascades. See
+      # https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs.
       always() &&
       (needs.check-workflow-run.result == 'success' || needs.check-workflow-run.result == 'skipped') &&
       (github.event_name != 'workflow_run' || fromJSON(needs.check-workflow-run.outputs.updated-refs)[0] != null)

diff --git a/.github/workflows/safari_technology_preview.yml b/.github/workflows/safari_technology_preview.yml
@@ -30,6 +30,9 @@ jobs:
     name: "All Tests: Safari Technology Preview"
     needs: check-workflow-run
     if: |
+      # We need always() here to then check for success/skipped from the dependency, as otherwise
+      # the skip cascades. See
+      # https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs.
       always() &&
       (needs.check-workflow-run.result == 'success' || needs.check-workflow-run.result == 'skipped') &&
       (github.event_name != 'workflow_run' || fromJSON(needs.check-workflow-run.outputs.updated-refs)[0] != null)