[Gecko Bug 1522790] Use marionette new window command to open wptrunner windows #45735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
css-scoping
html
infra
wptrunner
wpt-pr-bot
approved these changes
Apr 16, 2024
|
All the tests are passing now but it looks like that something is wrong with the sync task not ending correctly. WE most likely need an admin merge here. CC @web-platform-tests/admins |
Differential Revision: https://phabricator.services.mozilla.com/D23972 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790 gecko-commit: ed9818780499bbba8c5b606bd2632985ee3e5991 gecko-reviewers: jgraham
Depends on D23972 Differential Revision: https://phabricator.services.mozilla.com/D204234 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790 gecko-commit: d099e86e9a3f35890fbec91fef48fc0115f03480 gecko-reviewers: whimboo
…arguments. Depends on D206622 Differential Revision: https://phabricator.services.mozilla.com/D206623 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790 gecko-commit: 91d70d27459b254b2b9d8cf4b610c09e593ef369 gecko-reviewers: jgraham
lutien
force-pushed
the
gecko/1522790-2
branch
from
63074bc
to
2331399
Compare
lutien
force-pushed
the
gecko/1522790-2
branch
from
2331399
to
1478bbb
Compare
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Oct 14, 2024
Similar to web-platform-tests#48106, permission changes may leak between tests that use the same WebDriver session (i.e., browser process). For now, add a Chromium-specific `Browser.resetPermissions` call to reset permission defaults. To consolidate calls that reset state, refactor the WebDriver executor's testharness window management to align with web-platform-tests#45735.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D23972
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790
gecko-commit: ed9818780499bbba8c5b606bd2632985ee3e5991
gecko-reviewers: jgraham